fix: close #9771 fix comments with ( and )
#9800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I think I'll need help on this EDIT: thanks for sparring! This is now fixed. helix/runtime/queries/comment/highlights.scm Lines 1 to 4 in cc43e35 Is no longer needed with the new upstream grammar as far as I can tell. |
the-mikedavis
added
S-waiting-on-author
|
Thanks for the review! I'll remember to check against those scopes if I happen to be in this situation again 👍🏻 |
AlexanderBrevig
changed the title
( and )
the-mikedavis
approved these changes
Mar 4, 2024
the-mikedavis
added
S-waiting-on-review
archseer
approved these changes
Mar 8, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…tor#9800) * fix: close helix-editor#9771 update OCaml * fix: no longer match on ( ) as the underlying grammar handles these * fix: implement excellent corrections from review * fix: module -> namespace to match theme scopes
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…tor#9800) * fix: close helix-editor#9771 update OCaml * fix: no longer match on ( ) as the underlying grammar handles these * fix: implement excellent corrections from review * fix: module -> namespace to match theme scopes
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
…tor#9800) * fix: close helix-editor#9771 update OCaml * fix: no longer match on ( ) as the underlying grammar handles these * fix: implement excellent corrections from review * fix: module -> namespace to match theme scopes
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…tor#9800) * fix: close helix-editor#9771 update OCaml * fix: no longer match on ( ) as the underlying grammar handles these * fix: implement excellent corrections from review * fix: module -> namespace to match theme scopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jumped forward three years for the OCaml tree-sitter :)
Fixes #9771 for all languages.